-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make pest_generator / pest_derive no_std compatible. #513
Conversation
Again, I prefer crates being unconditionally I was going to say that you can unconditionally use |
Oh, I now remember why I originally did not make the tests unconditionally
That is why I think it is not a good idea to unconditionally use |
Is there anything that blocks the merge of this PR? |
@CAD97, @dragostis, what is the status on this? |
Should this be merged? |
This reverts commit f02921a.
I now reverted my commit that made the derive tests unconditionally |
Sorry that this has sat for so long. If you fix the conflict, I think I can merge this. We're still waiting on @dragostis for a publish, though. |
Ok, I fixed the conflict. From my POV, this is ready to merge. |
LGTM bors: r+ |
Build succeeded: |
Amazing! Thank you for merging this. |
This is the follow-up pull request to #498.
It adds "std" feature flags for both pest_generator and pest_derive.
Currently, the correct function of this can only be tested by running
cargo test --no-default-features
in thederive
directory.Running
cargo test --no-default-features
in the root directory unfortunately does not run the tests in no_std mode.