Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trait bound from Error type #694

Merged
merged 3 commits into from
Aug 16, 2022
Merged

Remove trait bound from Error type #694

merged 3 commits into from
Aug 16, 2022

Conversation

CAD97
Copy link
Contributor

@CAD97 CAD97 commented Aug 15, 2022

Fixes #693. Let's see what's wrong with the simple fix.

@CAD97 CAD97 requested a review from a team as a code owner August 15, 2022 23:43
@CAD97 CAD97 requested review from tomtau and removed request for a team August 15, 2022 23:43
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, likely this is fine, but I'd want to try if no_std is fine; i'll try to run (or anyone can try) rustup run nightly -- cargo build -j1 -Z build-std=core,alloc --target x86_64-unknown-linux-gnu --no-default-features on pest before merging it

@CAD97
Copy link
Contributor Author

CAD97 commented Aug 16, 2022

CAD97-patch-1:pest〉cargo clean
CAD97-patch-1:pest〉cargo bootstrap
   Compiling proc-macro2 v1.0.41
   Compiling unicode-ident v1.0.2
   Compiling quote v1.0.20
   Compiling syn v1.0.98
   Compiling ucd-trie v0.1.4
   Compiling maplit v1.0.2
   Compiling pest v2.1.3
   Compiling pest_meta v2.1.3
   Compiling pest_generator v2.1.3
   Compiling pest_bootstrap v0.0.0 (D:\git\pest-parser\pest\bootstrap)
    Finished dev [unoptimized + debuginfo] target(s) in 3.92s
     Running `D:\.rust\target\debug\pest_bootstrap.exe`
CAD97-patch-1:pest〉rustup run nightly -- cargo build -j1 -Z build-std=core,alloc --target x86_64-pc-windows-msvc -p pest --no-default-features
   Compiling compiler_builtins v0.1.79
   Compiling core v0.0.0 (D:\.rust\rustup\toolchains\nightly-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\core)
   Compiling rustc-std-workspace-core v1.99.0 (D:\.rust\rustup\toolchains\nightly-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\rustc-std-workspace-core)
   Compiling alloc v0.0.0 (D:\.rust\rustup\toolchains\nightly-x86_64-pc-windows-msvc\lib\rustlib\src\rust\library\alloc)
   Compiling ucd-trie v0.1.4
   Compiling pest v2.2.1 (D:\git\pest-parser\pest\pest)
    Finished dev [unoptimized + debuginfo] target(s) in 14.32s

@CAD97 CAD97 merged commit 0640862 into master Aug 16, 2022
@CAD97 CAD97 deleted the CAD97-patch-1 branch August 16, 2022 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change from 2.1.3 to 2.2.1 due to new RuleType bound on Error types
2 participants