chore: clippy fixes and ignores #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomtau
commented
Nov 9, 2022
vm/src/lib.rs
Outdated
Comment on lines
52
to
53
| #[allow(clippy::almost_complete_letter_range)] | ||
| fn parse_rule<'a, 'i>( |
There was a problem hiding this comment.
@pest-parser/triage One other possibility for this would be to introduce a new pub fn match_range_inclusive(mut self: Box<Self>, range: RangeInclusive<char>) -> ParseResult<Box<Self>> and use that in this function, and mark the old match_range as deprecated:
Line 685 in df487a6
code was fixed where possible; elsewhere it'd need API-breaking changes, so it was just annotated to allow that for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code was fixed where possible;
elsewhere it'd need API-breaking changes,
so it was just annotated to allow that for now.