Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: bump toolchain for check #978

Merged
merged 4 commits into from
Feb 12, 2024
Merged

ci: bump toolchain for check #978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4b459b8
ci: bump toolchain for check
tomtau Feb 12, 2024
c996b70
bump more pipeline toolchains
tomtau Feb 12, 2024
0752c7b
allow the existing partial_cmp
tomtau Feb 12, 2024
20077f7
fix `-` to `_`
tomtau Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
uses: ./.github/actions/setup
with:
kind: check
toolchain: 1.70.0
toolchain: 1.74.0 # needed for `clap` in pest_debugger
- name: cargo check
run: cargo check --all --features pretty-print,const_prec_climber,memchr,grammar-extras --all-targets

Expand All @@ -40,7 +40,7 @@ jobs:
with:
kind: check
components: clippy, rustfmt
toolchain: 1.70.0
toolchain: 1.74.0 # needed for `clap` in pest_debugger
- name: cargo fmt
run: cargo fmt --all -- --check
- name: cargo clippy
Expand All @@ -62,7 +62,7 @@ jobs:
id: setup
with:
kind: check
toolchain: 1.70.0
toolchain: 1.74.0 # needed for `clap` in pest_debugger
- name: cargo doc
run: cargo doc --all --features pretty-print,const_prec_climber,memchr,grammar-extras

Expand Down Expand Up @@ -123,7 +123,7 @@ jobs:
id: setup
with:
kind: check
toolchain: 1.70.0
toolchain: 1.74.0 # needed for `clap` in pest_debugger
- name: Check feature powerset
run: cargo hack check --feature-powerset --optional-deps --exclude-all-features --skip not-bootstrap-in-src,cargo --keep-going --lib --tests --ignore-private

Expand Down
1 change: 1 addition & 0 deletions pest/src/position.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,6 +463,7 @@ impl<'i> PartialEq for Position<'i> {

impl<'i> Eq for Position<'i> {}

#[allow(clippy::non_canonical_partial_ord_impl)]
impl<'i> PartialOrd for Position<'i> {
fn partial_cmp(&self, other: &Position<'i>) -> Option<Ordering> {
if ptr::eq(self.input, other.input) {
Expand Down
Loading