You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Upon reviewing the current utilization of the RocksDB within the review-database crate, it has been observed that there is room for improvement and efficiency gains. The focus of this issue is the Column Family titled "account policy", which is currently used to house a single entry - the "account policy key".
Considering the capacity of RocksDB's Column Families, the solitary use of this Column Family seems inefficient. There's an identified requirement to store additional configuration values within the RocksDB. To address this, it is proposed to repurpose the existing "account policy" Column Family to meet this need.
Suggested Modifications:
Rename the "account policy" Column Family to "config".
Update all instances in the code where this Column Family is referenced, replacing "account policy" with "config".
Refactor the functions responsible for the addition, retrieval, and deletion of entries from this Column Family, enabling them to handle multiple configuration values, not just the "account policy key".
Crucially, implement a database migration strategy to ensure the transition from the "account policy" Column Family to the "config" Column Family is smooth and does not result in data loss or system downtime.
Anticipated Advantages:
Utilizes the capabilities of RocksDB's Column Families more efficiently.
Consolidates the storage of various configuration values, streamlining access and modification processes.
The new name, "config", is more intuitive and descriptive, facilitating easier understanding for new contributors and improving overall maintainability.
The text was updated successfully, but these errors were encountered:
@minshaoaicers/review-web#41 It seems that #100 work needs to be preceded in order to do that work. Do you have an expected progress schedule?
I think #100 is not a prerequisite of aicers/review-web#41. #100 is about renaming that involves a bit complexity on the database side. It won't affect user side directly. And as such, it has a pretty low priority for now.
However, in order to accomplish aicers/review-web#41, database changes is inevitable. Please add an issue for review-database.
@minshaoaicers/review-web#41 It seems that #100 work needs to be preceded in order to do that work. Do you have an expected progress schedule?
I think #100 is not a prerequisite of aicers/review-web#41. #100 is about renaming that involves a bit complexity on the database side. It won't affect user side directly. And as such, it has a pretty low priority for now.
However, in order to accomplish aicers/review-web#41, database changes is inevitable. Please add an issue for review-database.
Upon reviewing the current utilization of the RocksDB within the review-database crate, it has been observed that there is room for improvement and efficiency gains. The focus of this issue is the Column Family titled "account policy", which is currently used to house a single entry - the "account policy key".
Considering the capacity of RocksDB's Column Families, the solitary use of this Column Family seems inefficient. There's an identified requirement to store additional configuration values within the RocksDB. To address this, it is proposed to repurpose the existing "account policy" Column Family to meet this need.
Suggested Modifications:
Anticipated Advantages:
The text was updated successfully, but these errors were encountered: