-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance backup::restore
function to support PostgreSQL in addition to RocksDB
#80
Comments
I am currently working on an implementation, referring to the restoration part of https://github.com/aicers/cli. To solve this, it looks like we need to choose one of 2 ways.
|
Which step requires the root privilege? |
The part of the |
Could we consider the option of creating a temporary directory that's writable for the REview process instead? This way, we can circumvent the need for superuser permissions during the process of moving data from existing postgresql to a temporary directory. It's generally a bad practice to run applications with root privileges unless absolutely necessary, due to the significant security risks involved. When a process runs with root privileges, it has unrestricted access to the system. This means it can read, write, and delete every file on your system, and it can execute any command. If any vulnerabilities exist within the application, an attacker could exploit them to gain full control over the system. |
- Added new module 'postgres' to support postgresql. - Enhance `backup::list`/`backup::create`/`backup::restore`/`backup::recovery` function to support postgresql. - Added `backup::purge_old_backups` for apply immediately after `num_backups_to_keep` is changed. Closes: petabi#71, petabi#76, petabi#80
- Added new module 'postgres' to support postgresql. - Enhance `backup::list`/`backup::create`/`backup::restore`/`backup::recovery` function to support postgresql. - Added `backup::purge_old_backups` for apply immediately after `num_backups_to_keep` is changed. Closes: petabi#71, petabi#76, petabi#80
- Added new module 'postgres' to support postgresql. - Enhance `backup::list`/`backup::create`/`backup::restore`/`backup::recovery` function to support postgresql. - Added `backup::purge_old_backups` for apply immediately after `num_backups_to_keep` is changed. Closes: petabi#71, petabi#76, petabi#80
- Added new module 'postgres' to support postgresql. - Enhance `backup::list`/`backup::create`/`backup::restore`/`backup::recovery` function to support postgresql. - Added `backup::purge_old_backups` for apply immediately after `num_backups_to_keep` is changed. Closes: petabi#71, petabi#76, petabi#80
- Added new module 'postgres' to support postgresql. - Enhance `backup::list`/`backup::create`/`backup::restore`/`backup::recovery` function to support postgresql. - Added `backup::purge_old_backups` for apply immediately after `num_backups_to_keep` is changed. Closes: petabi#71, petabi#76, petabi#80
- Added new module 'postgres' to support postgresql. - Enhance `backup::list`/`backup::create`/`backup::restore`/`backup::recovery` function to support postgresql. - Added `backup::purge_old_backups` for apply immediately after `num_backups_to_keep` is changed. Closes: petabi#71, petabi#76, petabi#80
- Added new module 'postgres' to support postgresql. - Enhance `backup::list`/`backup::create`/`backup::restore`/`backup::recovery` function to support postgresql. - Added `backup::purge_old_backups` for apply immediately after `num_backups_to_keep` is changed. Closes: petabi#71, petabi#76, petabi#80
- Added new module 'postgres' to support postgresql. - Enhance `backup::list`/`backup::create`/`backup::restore`/`backup::recovery` function to support postgresql. - Added `backup::purge_old_backups` for apply immediately after `num_backups_to_keep` is changed. Closes: petabi#71, petabi#76, petabi#80
- Added new module 'postgres' to support postgresql. - Enhance `backup::list`/`backup::create`/`backup::restore`/`backup::recovery` function to support postgresql. - Added `backup::purge_old_backups` for apply immediately after `num_backups_to_keep` is changed. Closes: petabi#71, petabi#76, petabi#80
Description
Currently, the
backup::restore
function is designed to restore backups for RocksDB only. This issue aims to enhance this function to support PostgreSQL as well.This change would involve not only restoring the state of the RocksDB store but also the PostgreSQL database from its corresponding backup. It's proposed to use
psql
command for restoring the PostgreSQL backup.Tasks
backup::restore
function to restore both RocksDB and PostgreSQL databases.psql
command to restore the PostgreSQL backup.Acceptance Criteria
backup::restore
function is able to restore both RocksDB and PostgreSQL backups.The text was updated successfully, but these errors were encountered: