Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imported project files modifications check #71

Merged
merged 5 commits into from
Oct 28, 2019

Conversation

IgorFedchenko
Copy link
Contributor

Close #68

The way this is going to work is getting all imported files paths from <Image Project="path/to/props"> tags of all projects in solution, and then checking if any of them were modified.

Will keep PR in draft until add some tests to verify this works well.

@Aaronontheweb
Copy link
Member

Sorry about this @IgorFedchenko - looks like I needed to update the Azure DevOps connection. Just did that. If you push 1 more commit that should trigger PR validation.

@IgorFedchenko
Copy link
Contributor Author

Sure, no problem

@IgorFedchenko IgorFedchenko marked this pull request as ready for review October 25, 2019 20:16
@IgorFedchenko
Copy link
Contributor Author

@Aaronontheweb I could add more tests for multiple imports cases, maybe multiple projects, etc - but there should not be much difference in how the code works in this cases

@IgorFedchenko
Copy link
Contributor Author

Seems like tests failed, but that is because it thinks that my "SampleProject.csproj" file, generated during tests execution, is a real project. Maybe it should ignore all files under bin directory?

Or, I will just add cleanup code now

@Aaronontheweb
Copy link
Member

Thanks @IgorFedchenko! I'll try running this locally and take a look at it. Appreciate the hard work.

@Aaronontheweb
Copy link
Member

@IgorFedchenko just validated this on the Akka.NET solution itself, which is where we're going to see this in action first. Worked like a charm. Thank you!

@Aaronontheweb Aaronontheweb merged commit 9b1d69d into petabridge:dev Oct 28, 2019
@IgorFedchenko IgorFedchenko deleted the props_tracking branch October 28, 2019 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to be able to detect changes in .props files referenced by projects
2 participants