Akka.Streams improvements #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
May 2, 2024
| Push(_stage.Out, packet); | ||
| else |
There was a problem hiding this comment.
This was a source of some major, major bugs for TurboMqtt - it resulted in us not consistently pulling the stages above us, therefore many QoS 1 / QoS 2 packets went unacknowledged
Aaronontheweb
commented
May 2, 2024
| @@ -72,89 +75,88 @@ private sealed class Logic : InAndOutGraphStageLogic | |||
| public Logic(ClientAckingFlow stage) : base(stage.Shape) | |||
| { | |||
| _stage = stage; | |||
| _publishIds = new SimpleLruCache<NonZeroUInt16>(stage._bufferSize, stage._bufferExpiry); | |||
| _pubRelIds = new SimpleLruCache<NonZeroUInt16>(stage._bufferSize, stage._bufferExpiry); | |||
There was a problem hiding this comment.
Profiled this - the explicit de-duplication code was actually a major source of slow-downs. Think O(N) for each message that came in. I'm rethinking whether or not this is the client's responsibility or not too - we should add the PacketId to the MqttMessage type if we want to pass the buck on de-duplication to the end-user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on some throughput improvements around QoS 1 / QoS 2 handling