Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more cases Grape::UnnecessaryNamespace #26

Merged
merged 3 commits into from
Oct 27, 2022

Conversation

Bhacaz
Copy link
Collaborator

@Bhacaz Bhacaz commented Oct 21, 2022

Fix #25

@Bhacaz Bhacaz force-pushed the unnecessary_namespace_endpoint_with_name branch 2 times, most recently from 6a3c301 to 3d21f1f Compare October 22, 2022 01:04
@Bhacaz Bhacaz force-pushed the unnecessary_namespace_endpoint_with_name branch from 3d21f1f to 091e051 Compare October 22, 2022 01:05
@Bhacaz Bhacaz changed the title Grape::UnnecessaryNamespace bug Support more cases Grape::UnnecessaryNamespace Oct 22, 2022
@Bhacaz Bhacaz marked this pull request as ready for review October 22, 2022 01:08
@AlbertChouinard
Copy link

@Bhacaz comment je peux tester? J'ai pull ta branche, suivi le readme et je reçois un

Run `rails db:migrate` to update your database then try again.

== Command ["bin/rails db:setup"] failed ==

même après rails db:migrate

@Bhacaz
Copy link
Collaborator Author

Bhacaz commented Oct 25, 2022

@AlbertChouinard 🤔 tu veux tester cette branch dans notre projet?

Pour ce faire:

  1. Dans le Gemfile modifier pour gem 'rubocop-petal', require: false, git: 'https://github.com/petalmd/rubocop-petal', branch: 'unnecessary_namespace_endpoint_with_name'
  2. bundle i
  3. bundle exec rubocop --only Grape/UnnecessaryNamespace -p app/api

Tu va installer rubocop-petal mais la version de cette branche et rouler juste la cop pour le dossier api.

Copy link

@MichelBiron MichelBiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sa fonctionne bien sur la branche en problème

@Bhacaz Bhacaz merged commit 7e52971 into main Oct 27, 2022
@Bhacaz Bhacaz deleted the unnecessary_namespace_endpoint_with_name branch October 27, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported cases Grape::UnnecessaryNamespace
3 participants