Snif cop

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 * Updated gemspec file. ([#30](https://github.com/petalmd/rubocop-petal/pull/30))
 * Added cop `RSpec/JsonParseResponseBody and RSpec/JsonResponse` ([#27](https://github.com/petalmd/rubocop-petal/pull/27))
+* Added cop `Performance/Snif` ([#27](https://github.com/petalmd/rubocop-petal/pull/31))
 
 # v0.7.0
 

config/default.yml

@@ -91,3 +91,7 @@ RSpec/JsonResponse:
   SafeAutoCorrect: true
   Include:
     - spec/**/*
+
+Performance/Snif:
+  Description: 'Prevent snif in favor of detect'
+  Enabled: true

lib/rubocop/cop/performance/snif.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Performance
+      # Prevent using `snif`.
+      # Consider using `detect`.
+      #
+      # @example
+      #   # bad
+      #   period.equity_packs.snif(:code, 'ONCALL')
+      #
+      #   # good
+      #   period.equity_packs.detect { |equity_pack| equity_pack.code == 'ONCALL' }
+      class Snif < Base
+        MSG = 'Use `detect` instead.'
+
+        def_node_matcher :snif?, <<~PATTERN
+          (send _ :snif _ _)
+        PATTERN
+
+        def on_send(node)
+          return unless snif?(node)
+
+          add_offense(node)
+        end
+      end
+    end
+  end
+end

spec/rubocop/cop/performance/snif_spec.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+RSpec.describe RuboCop::Cop::Performance::Snif, :config do
+  it 'registers an offense when using `snif`', :aggregate_failures do
+    expect_offense(<<~RUBY)
+      test.snif(:attribute, value)
+      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `detect` instead.
+    RUBY
+
+    expect_offense(<<~RUBY)
+      test.snif(attribute, value)
+      ^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `detect` instead.
+    RUBY
+  end
+end