Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Migration/StandaloneAddReference #54

Merged
merged 8 commits into from
Jun 19, 2023
Merged

Added Migration/StandaloneAddReference #54

merged 8 commits into from
Jun 19, 2023

Conversation

Bhacaz
Copy link
Collaborator

@Bhacaz Bhacaz commented Jun 17, 2023

Fix #53

@Bhacaz Bhacaz requested review from a team and byellokore and removed request for a team June 19, 2023 13:56
class StandaloneAddReference < Base
MSG = 'Modifying references must be done in a change_table block.'

RESTRICT_ON_SEND = %i[add_reference belongs_to remove_reference remove_belongs_to].freeze

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce que peut-être ici on doit ajouter le add_belongs_to et supprimer le belongs_to parce que seulement le belongs_to ne déclenche pas le cop si on ajoute le add_belongs_to.

@Bhacaz

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@Bhacaz Bhacaz marked this pull request as ready for review June 19, 2023 15:01
@Bhacaz Bhacaz requested a review from byellokore June 19, 2023 15:01
Copy link

@byellokore byellokore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Capture d’écran, le 2023-06-19 à 11 07 27 Capture d’écran, le 2023-06-19 à 10 33 09 Capture d’écran, le 2023-06-19 à 11 07 49 Capture d’écran, le 2023-06-19 à 11 08 05

@Bhacaz Bhacaz merged commit 6cf86b9 into main Jun 19, 2023
@Bhacaz Bhacaz deleted the limit_add_references branch June 19, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration/ChangeTableReferences doesn't cover all cases
2 participants