new cop for enum starting value #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Bhacaz
reviewed
Jun 20, 2023
This reverts commit 3ccf7e9. :q!
Bhacaz
reviewed
Jun 20, 2023
Bhacaz
requested changes
Jun 21, 2023
There was a problem hiding this comment.
I had some error when trying it our project. Sometimes, the enum value is a constant, example
undefined method `value' for s(:const, nil, :SomeConstant):RuboCop::AST::ConstNode
/Users/jfbastien/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/bundler/gems/rubocop-petal-f6edf46de432/lib/rubocop/cop/rails/enum_starting_value.rb:35:in `block in start_with_zero?'
/Users/jfbastien/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/bundler/gems/rubocop-petal-f6edf46de432/lib/rubocop/cop/rails/enum_starting_value.rb:34:in `any?'
/Users/jfbastien/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/bundler/gems/rubocop-petal-f6edf46de432/lib/rubocop/cop/rails/enum_starting_value.rb:34:in `start_with_zero?'
/Users/jfbastien/.rbenv/versions/2.6.6/lib/ruby/gems/2.6.0/bundler/gems/rubocop-petal-f6edf46de432/lib/rubocop/cop/rails/enum_starting_value.rb:30:in `on_send'
Bhacaz
reviewed
Jun 21, 2023
| it 'expects an offense' do | ||
| expect_offense(<<~RUBY) | ||
| class MyModel | ||
| enum my_enum: {state1: 0, state2: 2} |
There was a problem hiding this comment.
It may sound weird, but can you add a specs to that check that no value should be 0.
Like
enum my_enum: {state1: 1, state2: 0}
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is in response to this issue: #56