Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug with rounding ties to even #956

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Conversation

petamoriken
Copy link
Owner

Fixes #952

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (79ef5aa) 87.04% compared to head (c5cfc40) 87.04%.
Report is 31 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #956   +/-   ##
=======================================
  Coverage   87.04%   87.04%           
=======================================
  Files          12       12           
  Lines         772      772           
  Branches      142      146    +4     
=======================================
  Hits          672      672           
  Misses         54       54           
  Partials       46       46           
Flag Coverage Δ
unittests 87.04% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/_util/converter.mjs 100.00% <100.00%> (ø)
src/_util/primordials.mjs 87.36% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@petamoriken
Copy link
Owner Author

I will be implementing this with reference to IEEE754-2019

@petamoriken petamoriken force-pushed the fix/round-ties-to-even branch 3 times, most recently from 42a9636 to 2fc69fc Compare July 30, 2023 10:06
@petamoriken petamoriken marked this pull request as ready for review July 30, 2023 10:07
@petamoriken petamoriken merged commit 92e5f2c into master Jul 30, 2023
12 checks passed
@petamoriken petamoriken deleted the fix/round-ties-to-even branch July 30, 2023 10:21
@petamoriken petamoriken added the bug label Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conversions to float16 are incorrect for very small numbers
1 participant