Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to Python3 #17

Merged
merged 10 commits into from
May 18, 2017
Merged

Convert to Python3 #17

merged 10 commits into from
May 18, 2017

Conversation

ralic
Copy link
Contributor

@ralic ralic commented May 18, 2017

using : find . -name '*.py' | xargs 2to3 -w

@petebachant
Copy link
Owner

Thanks for the PR! I'd like the keep this package compatible with both Python 2 and Python 3, however. Can you first remove the *.bak files? Converting the print and xrange statements are great.

@ralic
Copy link
Contributor Author

ralic commented May 18, 2017

I've tested it and it works for both python2.7 and python3.6

@petebachant
Copy link
Owner

Looking good. If you bring back the from __future__ imports, it should be ready to merge.

@petebachant petebachant merged commit 1a82116 into petebachant:master May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants