New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed interpolate path split to allow / path #83

Open

kn1990 wants to merge 1 commit into petems:master from kn1990:fix-interpolate-pathroot

kn1990 commented Apr 11, 2022

Changes to the interpolate function to split the path has broken the vault lookups for us (Working in Release v1.0.0).

The interpolate function on line 343 (https://github.com/petems/petems-hiera_vault/blob/master/lib/puppet/functions/hiera_vault.rb#L343) does not account for "/" as a valid path, resulting in secrets under "/" path are not fetched

In our Puppet environment we have the following hiera.yaml:

- name: "Hiera-vault lookup"
    lookup_key: "hiera_vault"
    options:
      mounts:
        kv2:
          - "/"
          - "common"

PR is to update the string split to include "/" path


          Fixed interpolate path split to allow / paths

50312ee

Owner

petems commented Jul 15, 2022

Sorry for the delay, this looks like a good addition, I'll do some testing this weekend and should get this merged ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet