Handle 401s more gracefully...

[petems]

Related to #52

We should handle credentials being incorrect/expired in a nicer way. I think we'll have to do this upstream on digital_ocean and then pull in the changes.

We can have some sort of "Catch Faraday 401 error, tell the user to check their credentials and then exit" rather than the default full stacktrace that Faraday provides.

[pearkes]

Yea, the current implementation is really naive...working with what we have I guess.

My only concern with this – and maybe I'm alone in this opinion, please say so – is that it's a lot of extra HTTP calls for small UX benefit. I totally see the pluses, I just wish we didn't have to do something so expensive.

What do you thing @blom? Interesting to get another perspective here.

[pearkes]

OH! And by "this" I mean this branch, sorry.

I thought about doing something similar, but, yea, above.

[petems]

Yeah, that branch was me figuring out how hard it would be to do on tugboat, realised it was easier use the built in faraday middleware upstream 👍

[blom]

Yeah, I agree with @pearkes and for the same reasons.

[petems]

Ok, started from scratch so we can use our own custom middleware to catch status errors, much better solution, still a WIP but you can see what I'm aiming at: https://github.com/pearkes/tugboat/tree/pm_custom_faraday