Display + SSH to private IP #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display private IP when present, and default SSH to private IP, except if -e (use-external-ip) is set.
|
Looks good, but can you add tests? |
|
@petems Added :) |
|
Added tests + Fixed #108. |
|
I pulled your spec fix commit into a separate PR for easier tracking 😄 |
|
how do i install from upstream on my machine? |
|
Hi @oryband! Easiest way is to clone the repo, do a pull on master then run: We'll have release of the latest version soon! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display private IP when present, and default SSH to private IP, except if -e (use-external-ip) is set.