Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an initial spec for the ssh command #24

Merged
merged 1 commit into from
May 1, 2013
Merged

Conversation

blom
Copy link
Collaborator

@blom blom commented Apr 26, 2013

No description provided.

@pearkes
Copy link
Collaborator

pearkes commented Apr 27, 2013

I wonder if we can do a should_receive on the exec stub to inspect that the options are coming through clean. Unfortunately I don't for the life of me know how to properly integration test this, really.

Definitely a good start that covers the basics though.

@blom
Copy link
Collaborator Author

blom commented Apr 27, 2013

First I considered stubbing out Tugboat::Middleware::SSHDroplet#call entirely, but decided against it so that #call would be exercised in the tests for now. However, maybe we should stub out #call here and give it (and Kernel.exec) full attention elsewhere? Maybe this test is concerning itself too much with how #call is implemented, especially since it is testing the API call to DigitalOcean.

@pearkes
Copy link
Collaborator

pearkes commented May 1, 2013

You're right. I think for the "cli" tests this is fine - it covers what we need. I've written a handful of unit tests for the middleware, that might make sense for stubbing exec.

pearkes added a commit that referenced this pull request May 1, 2013
Add an initial spec for the ssh command
@pearkes pearkes merged commit b70ef99 into petems:master May 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants