Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes hashie warning for methods #264

Merged
merged 1 commit into from
Mar 18, 2017
Merged

Fixes hashie warning for methods #264

merged 1 commit into from
Mar 18, 2017

Conversation

petems
Copy link
Owner

@petems petems commented Mar 18, 2017 

W, [2017-03-18T22:33:20.253963 #55813]  WARN -- : You are setting a key that conflicts with a built-in method Hashie::Mash#size defined in Hash. This can cause unexpected behavior when accessing the key via as a property. You can still access the key via the #[] method.

@petems
Fixes hashie warning for methods
7e1d624 
```
W, [2017-03-18T22:33:20.253963 #55813]  WARN -- : You are setting a key that conflicts with a built-in method Hashie::Mash#size defined in Hash. This can cause unexpected behavior when accessing the key via as a property. You can still access the key via the #[] method.
```
* Properly fix later: hashie/hashie#391
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 98.0% when pulling 7e1d624 on remove_hashie_warning into 92ab349 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 98.0% when pulling 7e1d624 on remove_hashie_warning into 92ab349 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 98.0% when pulling 7e1d624 on remove_hashie_warning into 92ab349 on master.

@petems petems merged commit 71658dd into master Mar 18, 2017
@petems petems deleted the remove_hashie_warning branch March 18, 2017 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petems @coveralls