Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change listing droplets to use DK #284

Merged
merged 1 commit into from
Nov 21, 2017
Merged

Change listing droplets to use DK #284

merged 1 commit into from
Nov 21, 2017

Conversation

petems
Copy link
Owner

@petems petems commented Nov 16, 2017

  • Changes to use droplet_kit over Barge

@petems
Copy link
Owner Author

petems commented Nov 16, 2017

@lachesis can you try running a "droplet list" with this branch for me? I want to see if it's an issue with the barge library over droplet_kit

@coveralls
Copy link

coveralls commented Nov 16, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-1.5%) to 96.537% when pulling 9919ac7 on change_to_dropletkit_for_list_droplets into b00493d on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.5%) to 96.537% when pulling 9919ac7 on change_to_dropletkit_for_list_droplets into b00493d on master.

@petems petems force-pushed the change_to_dropletkit_for_list_droplets branch from 9919ac7 to fa9d370 Compare November 21, 2017 08:35
@coveralls
Copy link

coveralls commented Nov 21, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-1.4%) to 96.897% when pulling fa9d370 on change_to_dropletkit_for_list_droplets into ab41529 on master.

@petems petems force-pushed the change_to_dropletkit_for_list_droplets branch from fa9d370 to 659f235 Compare November 21, 2017 08:42
@coveralls
Copy link

coveralls commented Nov 21, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 98.094% when pulling 659f235 on change_to_dropletkit_for_list_droplets into ab41529 on master.

@petems petems force-pushed the change_to_dropletkit_for_list_droplets branch from 659f235 to 2d21e92 Compare November 21, 2017 21:21
@coveralls
Copy link

coveralls commented Nov 21, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 98.077% when pulling 2d21e92 on change_to_dropletkit_for_list_droplets into ab41529 on master.

@petems petems force-pushed the change_to_dropletkit_for_list_droplets branch from 2d21e92 to 2dedf1c Compare November 21, 2017 21:26
@coveralls
Copy link

coveralls commented Nov 21, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 98.114% when pulling 2dedf1c on change_to_dropletkit_for_list_droplets into ab41529 on master.

@petems petems force-pushed the change_to_dropletkit_for_list_droplets branch from 2dedf1c to e6564b9 Compare November 21, 2017 21:32
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.2%) to 96.127% when pulling e6564b9 on change_to_dropletkit_for_list_droplets into ab41529 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.2%) to 96.127% when pulling e6564b9 on change_to_dropletkit_for_list_droplets into ab41529 on master.

@coveralls
Copy link

coveralls commented Nov 21, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-2.2%) to 96.127% when pulling e6564b9 on change_to_dropletkit_for_list_droplets into ab41529 on master.

@petems
Change listing droplets to use DropletKit
fbdfbff 
* Changes to use droplet_kit over Barge
* droplet_kit self-paginates, so does not require
Logic for checking pagination. 
* Adds logic for catching errors returned from 
DropletKit, as it doesn’t have a `success?` method
@petems petems force-pushed the change_to_dropletkit_for_list_droplets branch from e6564b9 to fbdfbff Compare November 21, 2017 21:38
@coveralls
Copy link

coveralls commented Nov 21, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 98.114% when pulling fbdfbff on change_to_dropletkit_for_list_droplets into ab41529 on master.

@petems petems merged commit 0ea37d4 into master Nov 21, 2017
@petems petems mentioned this pull request Nov 22, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petems @coveralls