Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switches $stdout redirection to rspec method #285

Merged
merged 1 commit into from
Nov 19, 2017
Merged

Switches $stdout redirection to rspec method #285

merged 1 commit into from
Nov 19, 2017

Conversation

petems
Copy link
Owner

@petems petems commented Nov 18, 2017

@coveralls
Copy link

coveralls commented Nov 18, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.05%) to 97.978% when pulling 176feaf on refactor_to_use_to_stdout_matcher into b00493d on master.

@petems petems force-pushed the refactor_to_use_to_stdout_matcher branch from 176feaf to 48c178d Compare November 18, 2017 18:28
@coveralls
Copy link

coveralls commented Nov 18, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 98.074% when pulling 48c178d on refactor_to_use_to_stdout_matcher into b00493d on master.

@petems
Switches $stdout redirection to rspec method
03f4d70 
* Rspec 3 adds the `output(args).to_stdout` method
* http://rspec.info/blog/2014/05/notable-changes-in-rspec-3/#new-output-matcher
* Means it’s a lot easier to do things like run pry, as stdout isn’t stuck
* Refactoring tests to change to next method
* Increasing test coverage
@petems petems force-pushed the refactor_to_use_to_stdout_matcher branch from 48c178d to 03f4d70 Compare November 19, 2017 15:45
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 98.317% when pulling 03f4d70 on refactor_to_use_to_stdout_matcher into b00493d on master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 98.317% when pulling 03f4d70 on refactor_to_use_to_stdout_matcher into b00493d on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 98.317% when pulling 03f4d70 on refactor_to_use_to_stdout_matcher into b00493d on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 98.317% when pulling 03f4d70 on refactor_to_use_to_stdout_matcher into b00493d on master.

@petems petems merged commit 0d34686 into master Nov 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petems @coveralls