Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require json at the top to avoid 2.0.0 issues #80

Merged
merged 1 commit into from
Dec 23, 2013
Merged

require json at the top to avoid 2.0.0 issues #80

merged 1 commit into from
Dec 23, 2013

Conversation

pearkes
Copy link
Collaborator

@pearkes pearkes commented Dec 6, 2013

This should fix #79, I was getting this as well with ruby 2.0.0p247 (2013-06-27 revision 41674) [x86_64-darwin12.3.0]

I don't really know how Ruby stuff like this works so I would appreciate opinions. :)

@pearkes
Copy link
Collaborator Author

pearkes commented Dec 6, 2013

Also, Travis is testing 2.0.0, funny it didn't catch this. Does the mocking not hit JSON in the place?

@petems
Copy link
Owner

petems commented Dec 6, 2013

IIRC Travis will test against the latest patch version if you don't specify it? Let me check...

Ok, scratch that, looks like it doesn't:

$ ruby --version
ruby 2.0.0p247

@mattysads
Copy link

Is there anything blocking this merge?

@petems
Copy link
Owner

petems commented Dec 23, 2013

Nope, merging now. @pearkes can you do a gem release? 👍

petems added a commit that referenced this pull request Dec 23, 2013
require json at the top to avoid 2.0.0 issues
@petems petems merged commit 085df65 into master Dec 23, 2013
@petems petems deleted the json branch December 23, 2013 01:03
@pearkes
Copy link
Collaborator Author

pearkes commented Dec 24, 2013

@petems Yup, releasing!

@pearkes
Copy link
Collaborator Author

pearkes commented Dec 24, 2013

This has been released along with other changes.

@mattysads
Copy link

Thank you for knocking this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to authorize tugboat
3 participants