Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 #115

Merged
merged 8 commits into from
Sep 15, 2023
Merged

v3 #115

merged 8 commits into from
Sep 15, 2023

Conversation

peter-evans
Copy link
Owner

@peter-evans peter-evans commented Sep 15, 2023

Fixes: #92
Fixes: #106

@peter-evans peter-evans marked this pull request as ready for review September 15, 2023 15:04
@peter-evans peter-evans merged commit 5a6f828 into main Sep 15, 2023
5 checks passed
@yeikel
Copy link

yeikel commented Mar 6, 2024

Can you please backport #92 this to v2? (ie: node16? runtime)

I am running in a GHE environment that is still using node16

@peter-evans
Copy link
Owner Author

Hi @yeikel

I don't really want to support Node 16 runtime now because it's EOL. However, what you can do is fork this repository and then just change this line to node16, then it should run the action using the Node 16 runtime.

@yeikel
Copy link

yeikel commented Mar 8, 2024

Hi @yeikel

I don't really want to support Node 16 runtime now because it's EOL. However, what you can do is fork this repository and then just change this line to node16, then it should run the action using the Node 16 runtime.

Thanks, it just leaves a large population of users maintaining forks until Github Enterprise supports node20. But yeah, the change is minimal enough to make as you mentioned

@peter-evans
Copy link
Owner Author

peter-evans commented Mar 8, 2024

Thanks, it just leaves a large population of users maintaining forks until Github Enterprise supports node20. But yeah, the change is minimal enough to make as you mentioned

My understanding was that it's already supported (although I'm not too familiar with it myself). I think it requires updating the Actions runner to at least this version.

I would be very surprised if it's not supported, because Node 16 is now EOL.

@yeikel
Copy link

yeikel commented Mar 8, 2024

Thanks, it just leaves a large population of users maintaining forks until Github Enterprise supports node20. But yeah, the change is minimal enough to make as you mentioned

My understanding was that it's already supported (although I'm not too familiar with it myself). I think it requires updating the Actions runner to at least this version.

I would be very surprised if it's not supported, because Node 16 is now EOL.

It's possible that it is just my environment. Upgrades are difficult and take time

As we mentioned, forking is a fine option for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

accept body-path Replace existing commit
2 participants