Support no_proxy environment variable #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test repository=tillganster/create-pull-request ref=main build=true |
peter-evans
approved these changes
Aug 17, 2022
|
Hi @tillganster Thank you for contributing! This looks good to me. Merging! |
|
Released as |
|
@tillganster Just to let you know that I've switched out the proxy implementation in the latest release ( |
|
@tillganster Just to let you know that I'm planning to revise the proxy implementation again. Please see here for further details. |
|
@peter-evans Thanks for the information. Let me know if I can help or contribute in this context! |
|
If you are able to test the |
aleksandrychev
pushed a commit
to aleksandrychev/create-pull-request
that referenced
this pull request
Mar 4, 2024
Co-authored-by: TGANSTE <till.ganster@mercedes-benz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our case we have self hosted runners which are managed by our enterprise. All the proxy envvars are set in the runners itself.
And we would need the proxy if we would go to github.com but not if we use this action to create a PR in our self hosted github enterprise.
This change will check the environment variable
no_proxyand will only use proxy agent if the requested url is not part of this variable. Currently this only works without wildcards in the domains which are part ofno_proxy.Let me know if something like this is out of scope or if there should be further changes.