-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull request is in unstable status #355
Comments
👍 We're observing the same issue |
same error here some of my config details...
...and debug output that might help investigating the issue:
|
Since you all seemed to experience this at the same time, it's likely that it's an issue on GitHub's side. The action itself has not changed in any way. |
@peter-evans Thanks for the quick answer! |
@Celebrate-Reinhard I am a new user as well. |
Ah, my misunderstanding. In that case, please check that you are fulfilling the conditions described here: |
@peter-evans , yeah I've created a PAT and using it as a secret , auto merge is also enabled under the pull request setting. still getting the same message. |
@peter-evans @novotl @Celebrate-Reinhard My issue was that the automerge job was set to wait for the job that makes the state to be satisfied , which breaks the condition mentioned above .... |
Can you give more details how exactly you did it? I tried the same and split them up into two different workflows. -> Same error: While some checks are still running (and therefor the auto-merge requirements are not satisfied), the auto merge is already failing 🤔 In the screenshot the button already says "Merge pull request". I have the feeling that that is already wrong. Shouldn't that be anything like "prepare for automerge"? |
@Celebrate-Reinhard i also made sure that the automerge job runs first ` AutoMerge_PRClose:
create_virtual_environment: |
Thank you, @izavads!
This is exactly what I missed!
I also reverted my split and it's now again like desribed yesterday. Details for everyone with the same issue like me. This is how it should look like: I just had to define the CI jobs as "required before merging" Before, the CI jobs ran and they even could fail, but they were not required. So the PR was always in a merge ready state from the very beginning. And being in that state the auto-merge flag cannot be set; not by UI and not by @peter-evans 's action. |
@peter-evans suggestion for making your docu even clearer:
Thank you for your help and the great action you created! |
In our case another repo admin removed the branch protection rule, so there was no required condition to wait for and it could be merged immediately. After adding back the required check all works fine 👍 . |
I think this error should be caught and display a more helpful error message, basically extending the error message matching that was done in #345, I'll open a PR |
Thanks @williamboman Released as |
Hi ,
getting the below message when trying to use the action :
Request failed due to following response errors: - ["Pull request Pull request is in unstable status"]
The text was updated successfully, but these errors were encountered: