Fix cache invalidation with custom key generator #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevejalim
approved these changes
Dec 20, 2018
|
Thanks!! |
peterbe
referenced
this pull request
in mozilla-services/tecken
Dec 27, 2018
This PR updates [django-cache-memoize](https://pypi.org/project/django-cache-memoize) from **0.1.5** to **0.1.6**. <details> <summary>Changelog</summary> ### 0.1.6 ``` ~~~~~ - Fetch cache backend later to provide thread-safety `pull21 <https://github.com/peterbe/django-cache-memoize/pull/21>`_ - Fix cache invalidation with custom key generator `pull20 <https://github.com/peterbe/django-cache-memoize/pull/20>`_ ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/django-cache-memoize - Changelog: https://pyup.io/changelogs/django-cache-memoize/ - Repo: https://github.com/peterbe/django-cache-memoize </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
key_generator_callableargument, the decorator will use it to create the cache key, but theinvalidate()function will always use the default_make_cache_key, basically breaking invalidation in this case as demonstrated with the test.This PR ensures that it's used consistently in both cases.