Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox runs no tests #23

Merged
merged 5 commits into from
Dec 21, 2018
Merged

tox runs no tests #23

merged 5 commits into from
Dec 21, 2018

Conversation

peterbe
Copy link
Owner

@peterbe peterbe commented Dec 21, 2018

Fixes #22

@peterbe
Copy link
Owner Author

peterbe commented Dec 21, 2018

@Geekfish I'm not sure a review is needed here because if it passes in Travis it's probably good enough :)

Repository owner deleted a comment from codecov bot Dec 21, 2018
Repository owner deleted a comment from codecov bot Dec 21, 2018
Repository owner deleted a comment from codecov bot Dec 21, 2018
@codecov
Copy link

codecov bot commented Dec 21, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@590daee). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #23   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?      1           
  Lines             ?     39           
  Branches          ?      0           
=======================================
  Hits              ?     39           
  Misses            ?      0           
  Partials          ?      0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 590daee...f7f9c94. Read the comment docs.

@Geekfish
Copy link
Collaborator

@peterbe cool, LGTM! Happy to rebase once this is merged.

@peterbe peterbe merged commit b8eb534 into master Dec 21, 2018
@peterbe peterbe deleted the 22-tox-runs-no-tests branch December 21, 2018 17:13
@peterbe
Copy link
Owner Author

peterbe commented Dec 21, 2018

@Geekfish try now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants