Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache_alias kwarg to allow using non-default cache #6

Merged
merged 1 commit into from
Aug 10, 2018

Conversation

benspaulding
Copy link
Contributor

Thank you for this project. It is well written, documented, and tested, which made using and contributing to it simple. 🙇

I found a case in my application where being able to use a non-default cache was necessary. Is this a feature you would like to have?

@benspaulding
Copy link
Contributor Author

For some reason the build failed with Python 3.4, but I think Travis or some other piece was just having problems. It took a few rebuilds, but eventually it worked for me.

@fcurella
Copy link

I'd be interested in this feature too :)

@peterbe
Copy link
Owner

peterbe commented Aug 10, 2018

I am so sorry for having missed this. I most have missed the notification.
To prevent this from happening more in the future I've enabled Email notifications for all watched repos.

@peterbe peterbe merged commit 4674dfd into peterbe:master Aug 10, 2018
@codecov
Copy link

codecov bot commented Aug 10, 2018

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #6   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          36     37    +1     
=====================================
+ Hits           36     37    +1
Impacted Files Coverage Δ
src/cache_memoize/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d21cbdb...0a2dc55. Read the comment docs.

@peterbe
Copy link
Owner

peterbe commented Aug 10, 2018

https://pypi.org/project/django-cache-memoize/0.1.2/ released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants