Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(ci): Add Django@4 to tox #61

Merged
merged 1 commit into from
Apr 29, 2022
Merged

build(ci): Add Django@4 to tox #61

merged 1 commit into from
Apr 29, 2022

Conversation

DmytroLitvinov
Copy link
Contributor

Closes #59

@peterbe
Copy link
Owner

peterbe commented Apr 19, 2022

You might need to drop 3.5. Right? Whatever Django 4 says :)

@peterbe
Copy link
Owner

peterbe commented Apr 19, 2022

Yeah, Django 4 is Python 3.8 and up

@DmytroLitvinov
Copy link
Contributor Author

As for me opinion, I would do it as other packages in Django eco system do: they provide new release with support only for Django 2.2, 3.1, 3.2, 4.0 and Python 3.6^.

How do you see it, @peterbe ?

@peterbe
Copy link
Owner

peterbe commented Apr 20, 2022

As for me opinion, I would do it as other packages in Django eco system do: they provide new release with support only for Django 2.2, 3.1, 3.2, 4.0 and Python 3.6^.

I'm not entirely sure I understand you. But I'll phrase it myself and you can check if we are saying the same thing.

If someone needs to stick to Django 2, they can simply pin an old version of django-cache-memoize.
If we add support for Django 4.0 we'll just make a semver release and a big mention in the changelog that this project now only supports Python 3.8 and up.

@DmytroLitvinov
Copy link
Contributor Author

And why we can't just add Django@4 in the tox.ini without dropping Django 2.2,3.1,3.2? We only need use Python 3.8^ for Django@4.0.

My proposal is to add Django@4.0 right now without any release or something. There is no code changes or something and even we follow semver, we can add new patch release where we point out that we added Django@4.0 to tox.ini for testing that package. (But again - without code changes in the library I would not do release). This is more for us right now to see that current version of package can be installed for Django@4.0

@DmytroLitvinov DmytroLitvinov requested a review from peterbe April 22, 2022 05:06
Copy link
Owner

@peterbe peterbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@peterbe peterbe merged commit ef449fe into peterbe:master Apr 29, 2022
@DmytroLitvinov DmytroLitvinov deleted the add-django-4 branch April 29, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Django 4.0
2 participants