Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verbose option doesn't make sense any more when the algorithm is in the release #73

Closed
peterbe opened this issue Aug 29, 2018 · 0 comments
Closed

Verbose option doesn't make sense any more when the algorithm is in the release #73

peterbe opened this issue Aug 29, 2018 · 0 comments
Assignees
@peterbe

Comments

@peterbe
Copy link
Owner

peterbe commented Aug 29, 2018

When we started using pypi.org instead one important change was that now we can (almost) always get the digests as part of the JSON payload. Before we had to get each URL for each release file, download that file, and run pip on it to get the checksum. Instead now can we can just get it from .releases[<desired version][N].digests.sha256 for example. In https://pypi.org/pypi/psycopg2/json for example every release has a md5 and sha256 digest. So we don't need to process a specific URL.
@peterbe peterbe self-assigned this Aug 29, 2018
peterbe added a commit that referenced this issue Aug 29, 2018
@peterbe
don't print release URL in verbose mode if not necessary
3998aed 
Fixes #73
@peterbe peterbe mentioned this issue Aug 29, 2018
Merged
peterbe pushed a commit that referenced this issue Aug 29, 2018
Dont print release url in verbose mode if not necessary (#74)
d682470 
* don't print release URL in verbose mode if not necessary

Fixes #73

* tests and changelog update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterbe peterbe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peterbe