Support indented requirements #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Remove duplicate code from is_different_lines().
Rename new_lines to new_text where it is not list
peterbe
requested changes
Sep 4, 2019
Owner
peterbe
left a comment
peterbe
left a comment
There was a problem hiding this comment.
It needs a unit test that reflects what you mentioned in the issue. Great work!!
peterbe
changed the title
Owner
|
Note that I edited the PR title and PR description so GitHub would know to automatically close the issue when this PR lands. |
Contributor
Author
|
Added the test. Debugging missing trailing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112