Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function expand_python_version for "3.10" and upwards (fixes #184) #186

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

hartwork
Copy link
Collaborator

@peterbe peterbe merged commit a8024b4 into peterbe:master Sep 23, 2024
6 checks passed
@hartwork
Copy link
Collaborator Author

@peterbe is there chance that you could cut a new release 1.0.2 with this fix?

@hartwork
Copy link
Collaborator Author

@vishnuwazoku thanks for the testing and/or review! 👍

@peterbe
Copy link
Owner

peterbe commented Sep 23, 2024

@peterbe is there chance that you could cut a new release 1.0.2 with this fix?

Since I changed computer I lost my .pypirc file and I don't know how to create it or combine it with twine. .

@hartwork
Copy link
Collaborator Author

@peterbe should we jump on a voice call about it some time?

PS:

# cat ~/.pypirc 
[pypi]
username = __token__
password = CENSORED

PPS: # twine upload dist/*5.1.0*

@peterbe
Copy link
Owner

peterbe commented Sep 23, 2024

It's been so long since I did this! :)

❯ cat ~/.pypirc
[distutils]
index-servers =
    pypi

[pypi]
username = __token__
password = xxxxxxxxxxx

and

❯ rm -fr dist/
❯ python setup.py sdist bdist_wheel
❯ ls -l dist
total 72
-rw-r--r--  1 peterbe  staff  16356 Sep 23 17:55 hashin-1.0.2-py2.py3-none-any.whl
-rw-r--r--  1 peterbe  staff  17052 Sep 23 17:55 hashin-1.0.2.tar.gz

lastly

❯ twine upload dist/
Uploading distributions to https://upload.pypi.org/legacy/
ERROR    InvalidDistribution: Unknown distribution format: ''

@hartwork
Copy link
Collaborator Author

❯ twine upload dist/
Uploading distributions to https://upload.pypi.org/legacy/
ERROR    InvalidDistribution: Unknown distribution format: ''

@peterbe passing the the whole folder would be dangerous anyway (i.e. doing too much next time) but it seems you need filenames rather than folders anyway as per https://stackoverflow.com/a/65369679 . So twine upload dist/*1.0.2* is what I recommend.

@peterbe
Copy link
Owner

peterbe commented Sep 26, 2024

That seems to have worked.
https://pypi.org/project/hashin/1.0.2/

@hartwork
Copy link
Collaborator Author

@peterbe awesome, thank you! 👍

@hartwork hartwork deleted the issue-184-fix-expand-python-version branch October 18, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running hashin with Python versions >= 3.10 raises PackageError('No releases can be found....')
3 participants