Update CLASSIFY_EXE_RE to parse ntlk win package #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They've published nltk-3.2.4.win32.exe which hashin can't parse
|
Can you please add a unit test? |
chrispbailey
commented
Aug 8, 2018
| self.assertEqual(hashin.release_url_metadata(url), { | ||
| 'package': 'nltk', | ||
| 'version': '3.2.4', | ||
| 'python_version': mock.ANY, |
There was a problem hiding this comment.
The structure of nltk-3.2.4.win32.exe does not contain a python version so technically the release_url_metadata returns python_version=win32. I'm not going to change the regex any further because I don't know what the consequences of making the python_version optional are (there are not enough tests here to ensure this doesn't break anything).
|
So this change made it possible for you to install nltk on windows with |
|
Version 0.13.3 pushed to pypi. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you specify a python version, then hashin filters the releases but can't parse the win binary for the nltk package.