feat: deploy to s3 #411
Open
feat: deploy to s3 #411
+79
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
RaoHai
commented
Sep 24, 2024
RaoHai
commented
- 纯静态部署
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis pull request introduces the deployment configuration for deploying static content to S3. It includes changes to the GitHub Actions workflow and updates to the Next.js configuration to support static export. Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| - .github/workflows/aws-static.yml | ||
| - client/** | ||
| - assistant/** | ||
|
|
There was a problem hiding this comment.
Ensure that the AWS credentials used here are securely stored and not hard-coded. Consider using GitHub Secrets for sensitive information.
| @@ -6,7 +6,7 @@ const { withSentryConfig } = require("@sentry/nextjs"); | |||
|
|
|||
|
|
|||
| const nextConfig = { | |||
| ...process.env.NEXT_STANDALONE ? { output: "standalone" } :{}, | |||
| ...process.env.NEXT_STANDALONE ? { output: "export", ssr: false } :{}, | |||
There was a problem hiding this comment.
Setting ssr: false might have unintended side effects if your application relies on server-side rendering. Ensure this change is thoroughly tested.
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
RaoHai
force-pushed
the
feat/deploy-to-s3
branch
from
4050578
to
90604e8
Compare
RaoHai
force-pushed
the
feat/deploy-to-s3
branch
from
90604e8
to
3a01c03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.