Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/remove cors whitelist #416

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Fix/remove cors whitelist #416

merged 2 commits into from
Sep 26, 2024

Conversation

RaoHai
Copy link
Contributor

@RaoHai RaoHai commented Sep 26, 2024

No description provided.

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
petercat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 26, 2024 7:48am

Copy link

Walkthrough

This pull request removes the CORS whitelist and updates the authentication middleware to check the 'origin' header instead of 'referer'. Additionally, it adds traceback logging for HTTP exceptions.

Changes

File Summary
server/auth/middleware.py Updated authentication logic to use 'origin' header and added traceback logging for HTTP exceptions.
template.yml Removed CORS_ORIGIN_WHITELIST environment variable.

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
server/auth/middleware.py 76.47% <100.00%> (+1.47%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Contributor

@xingwanying xingwanying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@RaoHai RaoHai merged commit 28b936e into main Sep 26, 2024
5 checks passed
@RaoHai RaoHai deleted the fix/remove-cors-whitelist branch September 26, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants