Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix payload addition in SerialLink #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

grozail
Copy link

@grozail grozail commented Oct 16, 2018

Noticed that you had TODO to fix payload method. Previous behavior is quite confusing since it overrides dynamics of the last link instead of parameter recalculation.

@petercorke
Copy link
Owner

Why did you remove the jointdynamics method? It's quite independent of the payload change that you did? Also, do you have code that you used to test the new functionality that be folded into the unit tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants