Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing RNE for URDFs robots with fixed joints #408

Open
wants to merge 12 commits into
base: future
Choose a base branch
from

Conversation

niederha
Copy link

This PR should fix the RNE function allowing correct execution for robot having fixed joints. It should also improve RNE computations by actually taking into account the links inertia when specified.

This should fix the bug described in issue #368

Unit tests were added and expended appropriately but I would still appreciate a review from someone familiar with the code.

@niederha
Copy link
Author

EDIT: Noticed an issue with spatialinertia addition. Fixed it but not in the most elegant way. Now it should be working flawlessly

@petercorke
Copy link
Owner

Thanks for your interest in the toolbox. We made a separate fix for this problem and we'd like to compare the results of your code and unit tests with our own.

@adriencholet
Copy link

@petercorke Have you had the time to compare the results ? I'd love to know if I can use this fix safely!

@niederha
Copy link
Author

niederha commented Aug 22, 2024

Hello,
Happy to see that this request has been moving forward. Just FYI, I've been using this fix for about 6 months and have been able to control robots with it (KUKA IIWA 7 and 14). I haven't noticed any glaring red flags and results seemed similar to what you'd get with pinnochio. I haven't conducted detailed mathematical testing but qualitatively this seemed good enough... and faster.

Also I belive I made a small unrelated fix in commit 0fed750 where a unittest was needlessly skiped on linux. Let me know if we think we should roll back this commit and do it somewhere else.

@freezeLUO
Copy link

Your fix was very effective! I have to experiment with this fix temporarily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants