-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing RNE for URDFs robots with fixed joints #408
base: future
Are you sure you want to change the base?
Conversation
…on by one so the string approach didnt work
EDIT: Noticed an issue with spatialinertia addition. Fixed it but not in the most elegant way. Now it should be working flawlessly |
Thanks for your interest in the toolbox. We made a separate fix for this problem and we'd like to compare the results of your code and unit tests with our own. |
@petercorke Have you had the time to compare the results ? I'd love to know if I can use this fix safely! |
Hello, Also I belive I made a small unrelated fix in commit 0fed750 where a unittest was needlessly skiped on linux. Let me know if we think we should roll back this commit and do it somewhere else. |
Your fix was very effective! I have to experiment with this fix temporarily. |
This PR should fix the RNE function allowing correct execution for robot having fixed joints. It should also improve RNE computations by actually taking into account the links inertia when specified.
This should fix the bug described in issue #368
Unit tests were added and expended appropriately but I would still appreciate a review from someone familiar with the code.