Read buffer data in a browser-compatible way

Author: lsegal

lib/util.js

@@ -228,7 +228,8 @@ AWS.util = {
       }
 
       for (var i = 0; i < data.length; i++) {
-        crc = (crc>>>8) ^ tbl[(crc^data[i])&0xFF];
+        var code = data.readUInt8(i);
+        crc = (crc>>>8) ^ tbl[(crc^code)&0xFF];
       }
       return (crc ^ -1) >>> 0;
     },

test/util.spec.coffee

@@ -135,7 +135,7 @@ describe 'AWS.util.crypto', ->
     it 'returns the correct CRC32 value for binary data', ->
       buffer = new Buffer(4433);
       for i in [0...buffer.length]
-        buffer[i] = i % 256;
+        buffer.writeUInt8 i % 256, i
       expect(util.crc32(buffer)).toEqual(899332870)
 
     it 'handles String values', ->