add gzip compressor #303
add gzip compressor #303
Conversation
|
Tests? |
|
Added. I believe the test is set up correctly, can you confirm? |
| describe 'GzipCompressor' do | ||
|
|
||
| should 'compress and uncompress data using Zlib::GzipWriter/Reader' do | ||
| memcached(19127,nil,{:compress=>true,:compressor=>Dalli::GzipCompressor}) do |dc| |
There was a problem hiding this comment.
Change :compressor to :compessor and watch the spec still pass. You need to set some expectations to verify your methods are being called.
|
Roger that, please see the test now. |
|
Did you forget to push? There's no new commit. |
|
Nope, there is just one extra line: |
|
To be more precise, I force pushed over my existing branch to update the PR. |
|
Got it, thank you! |
|
Oh, if you want to update the changelog with a note about nginx / gzip compatibility, I bet some people would find that useful. |
|
Roger that, coming up. |
|
Do you want it listed in History.md under 2.6.0? |
|
That would be fine. |
|
Not sure why, but the PR button isn't showing up for this, feel free to grab it manually! |
added for ease-of-use with nginx serving gzipped data directly from memcached