This repository has been archived by the owner on Jul 31, 2024. It is now read-only.
Update extension pattern for asset file hashes #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pattern to match extensions on input file names allows for every character. This results in files named like `bundle.a2b2c3.js` to have their file hashes removed when their extensions are changed. To preserve file hashes, this change updates the pattern to allow for every character except a period (`.`) in file extensions.
|
I wasn't sure if this was the expected behavior or not, but the Babel plugin portion of the tool doesn't remove the hashes for the files. Also, thanks for tool, it definitely saved me some time 👍🏽 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pattern to match extensions on input file names allows for every character. This results in files named like
bundle.a2b2c3.jsto have their file hashes removed when their extensions are changed. To preserve file hashes, this change updates the pattern to allow for every character except a period (.) in file extensions.