Adds support for hex values, rgba strings, malformed values with fail… #419
Conversation
|
It seems the travis integration consistently fails with Node < 6, maybe specifying a node minimum version would benefit the project too ! |
Codecov Report
@@ Coverage Diff @@
## master #419 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 19 20 +1
Lines 701 742 +41
=====================================
+ Hits 701 742 +41
Continue to review full report at Codecov.
|
|
@Lucassifoni This looks awesome. It looks like we need to get some tests in place to validate the fixes. Let me know if you need any help writing those tests. I'd love to help! |
lib/lost-utility.js
Outdated
| return [0, 0, 255]; | ||
| } | ||
|
|
||
| var testRgb = new RegExp(/rgb/); |
There was a problem hiding this comment.
It sounds silly, but could this either be at the top or the bottom of the file? In the middle for a "const" feels a bit odd.
There was a problem hiding this comment.
I updated organization and added tests, it should be green for both tests & lints now.
Thanks for your guidance.
|
It also looks like a lint failed here: https://travis-ci.org/peterramsing/lost/jobs/427015147#L1112. I've been looking into the lint config. I'm hesitant to turn this off but it has been falsely failing. Feel free to add |
|
@peterramsing Hi Peter, thanks for your feedback. |
|
This is lovely. I'm inspired by your code style. I'm gonna do some refactors of my own. Thanks for some awesome code! |
|
...as for the package-lock? meh... I'm not sure why that's there but I'm doing some refactors that will blow that away so I'm not too worried about that. |
See issue #418 .
I added some test cases, but the coverage significantly dropped.
Still, function types match and should provide a safety net.
Have a nice day !