Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenJDK6 to travis deps #11

Merged

Conversation

WickedShell
Copy link
Contributor

@WickedShell WickedShell commented Jan 11, 2018

Attempting to fix the OpenJDK6 error in #10

EDIT: I really should just enable Travis on my fork rather then using PR's to do Travis runs.

@peterschwarz
Copy link
Owner

It looks like Travis has changed how lein projects have to be specified (it has been a long time since this was setup). lein2 is now just lein and the old version is now lein1. If you could update this PR with that change, that would be cool

@peterschwarz
Copy link
Owner

@WickedShell
Copy link
Contributor Author

Will do, unfortunately its still running the jdk switcher before install apt packages, so I need to force the package to happen first.

@WickedShell
Copy link
Contributor Author

Side note (since you seem to be around), any chance of updating the released/stable version anytime soon? I've been tagged off of the snapshot after #8 was merged without any issues on Windows/Linux/Mac.

@WickedShell
Copy link
Contributor Author

Fixed lein, but that brings me back to the error that #10 was attempting to fix...

@WickedShell WickedShell force-pushed the wickedshell/travis-java6 branch 2 times, most recently from 0b41f13 to f28eb13 Compare January 11, 2018 21:27
@WickedShell
Copy link
Contributor Author

Okay this approach to Travis works, although it's a bit messy. Rather then running each task as a it's own build job this runs them all in one job (which given how fast it is to run it I think is quite reasonable). Definitely don't merge it with the commit to project.clj, that was just a work around to see travis pass.

This unfortunately breaks on major/minor versions again, and oraclejdk isn't default installed either anymore... Realistically we should probably be testing JDK8 and JDK9 these days. I'll probably look at adding the OpenJDK versions. With that done though is there a preference for which OracleJDK is tested? If we are willing to move from OracleJDK7 to OracleJDK8 it's provided in the trusty image for us already and is easy.

@WickedShell
Copy link
Contributor Author

If we drop Java6 support this is all very easy. Unfortunately all the recent build of PureJavaComm don't support Java6, and they have even updated some old released versions at some point. (I used to have an older machine that could grab an appropriate old jar file, but I deleted my maven cache one day and the resource I wanted had been replaced with a newer JVM requirement)

@peterschwarz
Copy link
Owner

I'm actually fine with dropping JDK6 support.

@WickedShell
Copy link
Contributor Author

We'd have to drop Java7 as well and that's a bit more painful... (I hadn't read far enough down). I don't need Java7 personally, but thats much more likely to still be in deployment somewhere. (Effectively we have already dropped support for Java7 because if you grab the resources today it won't work).

Given that a new clone doesn't work with Java 6 or Java 7 at this point until they release a version that adds support back in, I suggest just dropping it from the test env since it's already broken outside of us.

@WickedShell
Copy link
Contributor Author

Alright if everyone is happy with only testing Java 8 and 9 this resolves the CI problems, closes #9 and #10

@peterschwarz peterschwarz merged commit 9b4aa68 into peterschwarz:develop Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants