-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenJDK6 to travis deps #11
Add OpenJDK6 to travis deps #11
Conversation
It looks like Travis has changed how lein projects have to be specified (it has been a long time since this was setup). |
Will do, unfortunately its still running the jdk switcher before install apt packages, so I need to force the package to happen first. |
410f0d7
to
81b94a0
Compare
Side note (since you seem to be around), any chance of updating the released/stable version anytime soon? I've been tagged off of the snapshot after #8 was merged without any issues on Windows/Linux/Mac. |
Fixed lein, but that brings me back to the error that #10 was attempting to fix... |
0b41f13
to
f28eb13
Compare
Okay this approach to Travis works, although it's a bit messy. Rather then running each task as a it's own build job this runs them all in one job (which given how fast it is to run it I think is quite reasonable). Definitely don't merge it with the commit to project.clj, that was just a work around to see travis pass. This unfortunately breaks on major/minor versions again, and oraclejdk isn't default installed either anymore... Realistically we should probably be testing JDK8 and JDK9 these days. I'll probably look at adding the OpenJDK versions. With that done though is there a preference for which OracleJDK is tested? If we are willing to move from OracleJDK7 to OracleJDK8 it's provided in the trusty image for us already and is easy. |
If we drop Java6 support this is all very easy. Unfortunately all the recent build of PureJavaComm don't support Java6, and they have even updated some old released versions at some point. (I used to have an older machine that could grab an appropriate old jar file, but I deleted my maven cache one day and the resource I wanted had been replaced with a newer JVM requirement) |
I'm actually fine with dropping JDK6 support. |
212fe48
to
e07e63c
Compare
We'd have to drop Java7 as well and that's a bit more painful... (I hadn't read far enough down). I don't need Java7 personally, but thats much more likely to still be in deployment somewhere. (Effectively we have already dropped support for Java7 because if you grab the resources today it won't work). Given that a new clone doesn't work with Java 6 or Java 7 at this point until they release a version that adds support back in, I suggest just dropping it from the test env since it's already broken outside of us. |
cb95730
to
7513dc2
Compare
Attempting to fix the OpenJDK6 error in #10
EDIT: I really should just enable Travis on my fork rather then using PR's to do Travis runs.