Add support for cookie file authentication #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petertodd
added a commit
that referenced
this pull request
Aug 23, 2017
4f5bca8 Add support for cookie file authentication (Hielke Christian Braun) Pull request description: Use the .cookie file from the bitcoin config folder if there is no rpcpassword specified in the bitcoin.conf file. Also removes username/password from service url. Credentials are already in the authorization field. Sending them via both methods should not be necessary https://en.wikipedia.org/wiki/Basic_access_authentication Tree-SHA512: cdf74f62b9918a6c8da237e6a95ceb1a6e8ab3b05e392f7f67c34f6c574a5dff5acf20a20f1564cb7746432460e7fcdc64cd3586adba6a291479872ad38071de
|
Thanks! I also added support for regtest/testnet cookies in 5f77336 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the .cookie file from the bitcoin config folder if there is no rpcpassword specified in the bitcoin.conf file. Also removes username/password from service url. Credentials are already in the authorization field. Sending them via both methods should not be necessary
https://en.wikipedia.org/wiki/Basic_access_authentication