Skip to content

Add support for Dogecoin #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add support for Dogecoin #39

wants to merge 1 commit into from

Conversation

rnicoll
Copy link
Contributor

@rnicoll rnicoll commented Jan 1, 2015

Adds a second optional parameter to SelectParams() and SelectCoreParams() to enable multiple coin support, and adds Dogecoin as an example.

This is currently extremely naive (for example subsidy halving interval is used differently in Dogecoin difficulty calculations), however this is enough to enable basic usage with dogecoind.

Feedback would be greatly appreciated.

@petertodd
Copy link
Owner

A better way to do this is to create a dogecoin-bitcoinlib fork of this library. Or create a dogecoin-bitcoinlib that depends on python-bitcoinlib, and rewrites params as needed. I'd be interested in seeing what solution works best; I suspect the latter.

I won't be adding any altcoin support to python-bitcoinlib itself.

CC: @btcdrak

@rnicoll
Copy link
Contributor Author

rnicoll commented Jan 3, 2015

A wrapper around bitcoinlib makes sense. There's a few more complicated cases I haven't started work on yet (AuxPoW support, for example), but they should all be possible by creating extension classes I think.

@petertodd
Copy link
Owner

Sounds reasonable to me. Is your in-progress work up somewhere?

@rnicoll
Copy link
Contributor Author

rnicoll commented Jan 4, 2015

If you mean for a wrapper library; not yet, and need move other projects along for a bit, will come back to this later.

If you mean for the cross-chain stuff, https://github.com/rnicoll/cate - it's essentially enough to prove the theory, although lack of transaction replacement support in Bitcoin/Dogecoin Core means the refund transactions can block the actual payment transactions, so need to look at that.

@petertodd
Copy link
Owner

Thanks! I'll take to look at that code soon.

@rnicoll rnicoll deleted the master-dogecoin branch January 5, 2015 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants