Perform an overall code cleanup #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI seems to be failing because of unreachable codecov. |
petertrr
reviewed
Apr 9, 2024
| return if (!snake && prev != null) { | ||
| prev.previousSnake() | ||
| } else { | ||
| this | ||
| } | ||
| } | ||
|
|
||
| override fun toString() = generateSequence(this) { it.prev } | ||
| .joinToString(prefix = "[", postfix = "]") { "(${it.i}, ${it.j})" } | ||
| override fun toString(): String { |
There was a problem hiding this comment.
Why rewrite this method? For me, the existing implementation feels Kotlin-idiomatic
There was a problem hiding this comment.
Mainly two reasons:
- like with one class per file, an implementation closer to the upstream Java one helps in porting future changes
- we need to keep in mind readability. While
generateSequence + joinToStringis definitely more kotlinesque, understanding what's happening when you approach it is much more challenging. With a sequential solution you immediately infer what the result will be.
src/commonMain/kotlin/io/github/petertrr/diffutils/text/DiffRow.kt
Outdated
Show resolved
Hide resolved
src/commonTest/kotlin/io/github/petertrr/diffutils/DiffUtilsTest.kt
Outdated
Show resolved
Hide resolved
src/commonMain/kotlin/io/github/petertrr/diffutils/algorithm/myers/MyersDiff.kt
Show resolved
Hide resolved
src/commonMain/kotlin/io/github/petertrr/diffutils/algorithm/myers/MyersDiff.kt
Outdated
Show resolved
Hide resolved
lppedd
commented
Apr 10, 2024
2 seems too restrictive, and it may actually reduce readability.
…ingConflictOutput
Explicit throws indicator are not idiomatic to Kotlin, and they tend to become out of sync pretty fast with the actual code that is *supposed* to throw.
lppedd
force-pushed
the
refactor/cleanup
branch
from
bebe3e7 to
04efa7a
Compare
|
Thank you! I'll try to get code coverage up with one of the following PRs to port the java-diff changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title, this is just a cleanup to enhance readability or remove unused/duplicated APIs.
I've split each cleanup action into its own commit to make it easier to review them.