Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to fixedbitset 0.5.0 #617

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

james7132
Copy link

Finally got around to fixing the issues with fixedbitset. This PR updates fixedbitset to 0.5.0.

@bluss
Copy link
Member

bluss commented Mar 2, 2024

nice. breaking by being a public dependency so care needed, needs version bump in petgraph too, I think?

@james7132
Copy link
Author

If that's the case, should I remove those reexports? There may be more breaking changes in the near future with the SIMD acceleration work that has yet to land.

@bluss
Copy link
Member

bluss commented Mar 6, 2024

Not a reexport but a trait impl, I don't see how it can be removed right now.

Maybe https://docs.rs/petgraph/0.6.4/petgraph/visit/trait.Visitable.html with the associated type that links Graph to Graph::Map == FixedBitSet is the more clear example. I.e. that means FixedBitSet is in Graph's (an others) public API.

@bluss bluss added this to the 0.7.0 milestone Mar 6, 2024
@james7132
Copy link
Author

Note the SIMD changes made it in without another minor version bump. This should be the only breaking change.

@bluss
Copy link
Member

bluss commented Mar 22, 2024

Here is info, just for clarification:

  • Fixedbitset is a public dependency
    • meaning: it's in the public api of petgraph
  • 0.4.* to 0.5.* is not a default automatic upgrade in cargo

Those facts are enough to say this PR is a breaking change in petgraph, the contents of the library or the change in it doesn't matter.

@james7132
Copy link
Author

Right I was just mentioning that this is likely to be the only breaking change from updating FixedBitset, as the major changes have landed without needing to bump the minor version further.

@JMS55
Copy link

JMS55 commented Jun 14, 2024

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants