Checking for MutationObserver not in global #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment the scheduler checks MutationObserver and then assigning global.MutationObserver - causes a lot of fun in IE 11 extensions.
|
Can't reproduce the IE10 problem with Spin.js, I'll try more spinners and promises to load it soon. The problem is that the IE dev-tools crash long before I'm able to reach any conclusion - I'll write a better test. |
petkaantonov
added a commit
that referenced
this pull request
Mar 2, 2014
Checking for MutationObserver not in global
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the scheduler checks MutationObserver and then assigning global.MutationObserver - causes a lot of fun in IE 11 extensions.
Also, @stefanpenner warned me IE10 does strange things when using MutationObserver:
http://codeforhire.com/2013/09/21/setimmediate-and-messagechannel-broken-on-internet-explorer-10/
cujojs/when#197
To be fair, I haven't run into any issues myself running promises on the page, but then again I did not run it with spin.js - I'll try to reproduce