add tapError #1220

benjamingr · 2016-08-31T15:59:03Z

Adds Promise.prototype.tapError to bluebird.

The tests for the predicate version aren't passing yet (not sure why) and the doc is still missing, will hopefully follow up with those before I run out of momentum.

joepie91 · 2016-08-31T17:12:57Z

Hmm. Is this meant to be equivalent to .error or to .catch?

petkaantonov · 2016-08-31T17:44:01Z

There should also be cancellation tests, see how .tap is tested in test/cancel.js

petkaantonov · 2016-08-31T17:45:13Z

docs/docs/api/tapError.md

@@ -0,0 +1,128 @@
+---
+layout: api
+id: tap


benjamingr · 2016-08-31T19:58:24Z

Hmm. Is this meant to be equivalent to .error or to .catch?

To .catch (both the catch all variant and the filtered one.

joepie91 · 2016-08-31T20:19:26Z

To .catch (both the catch all variant and the filtered one.

Hmm, shouldn't we name it .tapCatch then? Otherwise, I can see this causing some confusion for users, thinking that it's equivalent to .error.

petkaantonov · 2016-09-01T07:04:05Z

Yeah tapCatch is probably a better name for this

benjamingr · 2016-09-01T07:43:46Z

Renaming to catch.
Fixing the doc issues.
I don't see tap in the cancellation tests.
Using the same NEXT_FILTER.

Predicates still don't work, PTAL.

petkaantonov · 2016-09-01T08:24:04Z

src/finally.js

+        return this._passThrough(handler,
+                                 TAP_TYPE,
+                                 undefined,
+                                 catchFilter(predicate, handler, this));


it should be catchFilter(predicate, finallyHandler, this)

wow, I spent like 20 minutes thinking what I'm not understanding in catchFilter and it ended up being a mistype -_-

also on top of modifying the finallyHandler, it should probably be:

return this._passThrough(catchFilter(predicate, handler, this), TAP_TYPE, undefined, finallyHandler);

That doesn't fix it either.

petkaantonov · 2016-09-01T08:28:58Z

I don't see tap in the cancellation tests.

never mind then, remembered wrong

benjamingr · 2016-09-01T08:30:40Z

@petkaantonov do we really need to support the multi parameter syntax? I'm fine with just supporting .tapCatch(e => {}) and .tapCatch(type|predicate, e => {})

petkaantonov · 2016-09-01T08:31:04Z

test/mocha/tapCatch.js

+
+describe("tap", function () {
+    specify("passes through rejection reason", function() {
+        return Promise.reject("test").tapError(function() {


Use new Error and assign it to variable, because this will cause a warning

petkaantonov · 2016-09-01T09:02:53Z

No but the predicate should still be type checked at this point, otherwise confusing error will happen at some later point

benjamingr · 2016-09-01T09:04:28Z

Addressed the feedback but predicate tests still don't pass.

petkaantonov · 2016-09-01T09:16:41Z

The finallyHandler needs to be modified to:

if (ret === NEXT_FILTER) {
    return ret;
} else if (ret !== undefined) {
    ...

benjamingr · 2016-09-01T09:24:31Z

Still no dice

petkaantonov · 2016-09-01T09:56:26Z

Run it individually to see the reason for failure node tools/test --run=tapCatch, for instance you have typed RefernceError instead of ReferenceError in one of the predicate tests

benjamingr · 2016-09-01T12:19:23Z

I did, that's not why it's failing. I see an assertionError, I don't really understand catchFilter very well - any chance you could take a look tonight before you release and see what I did wrong?

benjamingr · 2016-09-09T19:04:39Z

Ping @petkaantonov

dciccale · 2016-09-27T18:41:12Z

docs/docs/api-reference.md

@@ -53,7 +53,7 @@ redirect_from: "/docs/api/index.html"
    - [Promise.using](api/promise.using.html)
    - [.disposer](api/disposer.html)
 - [Promisification](api/promisification.html)
-    - [Promise.promisify](api/promise.promisify.html)
+    - [Promise.promisify](api/promsie.promisify.html)


Retsam · 2017-02-27T21:27:48Z

src/finally.js

+    } else {
+        var predicate = arguments[0];
+        var handler = arguments[1];
+       return this._passThrough(catchFilter(predicate, handler, this),


It looks like catchFilter is expecting an array of predicates, not a single predicate; this is why the "Works with predicates" test is failing.

Retsam · 2017-02-27T21:28:25Z

test/mocha/tapCatch.js

+            called = true;
+        }).then(assert.fail, function(err) { 
+            assert(called === false);
+            assert(err instanceof ReferenceError);


I'm pretty sure this should be err instanceof TypeError.

Retsam · 2017-02-27T21:33:46Z

I'd love to see this feature go in; I've opened #1351 as an extension of this PR with my fixes for most of the above issues. (~~Still need to add type checking for predicates~~)

* Fix typo: ReferneceError -> ReferenceError * Fix typo: promsie -> promise * s/tapError/tapCatch/g * Pass an array of predicates to catchFilter in tapCatch * Fix tapCatch tests * Add support for multiple predicates and predicate type checking

add tapError

471a485

benjamingr mentioned this pull request Aug 31, 2016

second argument for .tap or similar method for rejections #517

Closed

benjamingr added 2 commits August 31, 2016 19:13

document tapError

082b775

add to API reference

49e2a61

petkaantonov reviewed Aug 31, 2016
View reviewed changes

docs/docs/api/tapError.md Outdated

@@ -0,0 +1,128 @@

---

layout: api

id: tap

Copy link

Owner

petkaantonov Aug 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tapError

benjamingr reacted with thumbs up emoji

rename to tapCatch and export NEXT_FILTER

ed4f365

petkaantonov reviewed Sep 1, 2016
View reviewed changes

fix tests, attempt to fix predicates

6211fa1

feedback

9b4ccbf

dciccale reviewed Sep 27, 2016

View reviewed changes

spion mentioned this pull request Oct 1, 2016

putting catch before then in the chain, intended behavior? #1251

Closed

Retsam reviewed Feb 27, 2017

View reviewed changes

Retsam mentioned this pull request Feb 27, 2017

Fixes to tapError implementation/tests #1351

Merged

petkaantonov merged commit 053d02e into master Mar 3, 2017

petkaantonov deleted the add-tapErrr branch March 3, 2017 21:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add tapError #1220

add tapError #1220

benjamingr commented Aug 31, 2016

joepie91 commented Aug 31, 2016 •

edited

Loading

petkaantonov commented Aug 31, 2016

petkaantonov Aug 31, 2016

benjamingr commented Aug 31, 2016

joepie91 commented Aug 31, 2016

petkaantonov commented Sep 1, 2016

benjamingr commented Sep 1, 2016

petkaantonov Sep 1, 2016

benjamingr Sep 1, 2016

petkaantonov Sep 1, 2016

benjamingr Sep 1, 2016

petkaantonov commented Sep 1, 2016

benjamingr commented Sep 1, 2016

petkaantonov Sep 1, 2016

petkaantonov commented Sep 1, 2016

benjamingr commented Sep 1, 2016

petkaantonov commented Sep 1, 2016

benjamingr commented Sep 1, 2016

petkaantonov commented Sep 1, 2016

benjamingr commented Sep 1, 2016

benjamingr commented Sep 9, 2016

dciccale Sep 27, 2016

Retsam Feb 27, 2017

Retsam Feb 27, 2017

Retsam commented Feb 27, 2017 •

edited

Loading

add tapError #1220

add tapError #1220

Conversation

benjamingr commented Aug 31, 2016

joepie91 commented Aug 31, 2016 • edited Loading

petkaantonov commented Aug 31, 2016

Choose a reason for hiding this comment

benjamingr commented Aug 31, 2016

joepie91 commented Aug 31, 2016

petkaantonov commented Sep 1, 2016

benjamingr commented Sep 1, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

petkaantonov commented Sep 1, 2016

benjamingr commented Sep 1, 2016

Choose a reason for hiding this comment

petkaantonov commented Sep 1, 2016

benjamingr commented Sep 1, 2016

petkaantonov commented Sep 1, 2016

benjamingr commented Sep 1, 2016

petkaantonov commented Sep 1, 2016

benjamingr commented Sep 1, 2016

benjamingr commented Sep 9, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Retsam commented Feb 27, 2017 • edited Loading

joepie91 commented Aug 31, 2016 •

edited

Loading

Retsam commented Feb 27, 2017 •

edited

Loading