Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving publication after deleting or cancelling an identifier leaves database in inconsistent state #29

Closed
petkivim opened this issue Sep 30, 2016 · 1 comment

Comments

@petkivim
Copy link
Owner

petkivim commented Sep 30, 2016

How to reproduce the problem:

  • create a new ISBN request
  • generate ISBN identifier for the publication
  • delete or cancel the generated identifier on edit publication view
  • save the publication form
  • reload the page
  • the identifier is still stored in publication table, but removed elsewhere from the system

The cause for the problem is that the hidden input fields containing the source of the data are not updated when the identifier is deleted.

<input name="jform[publication_identifier_print]" id="jform_publication_identifier_print" value="{&quot;978-952-xx-xxxx-x&quot;:&quot;PAPERBACK&quot;}" type="hidden">
<input name="jform[publication_identifier_electronical]" id="jform_publication_identifier_electronical" value="{&quot;978-952-xx-xxxx-x&quot;:&quot;PDF&quot;}" type="hidden">
@petkivim petkivim changed the title Saving publication after permanently deleting an identifier leaves database in inconsistent state Saving publication after deleting or cancelling an identifier leaves database in inconsistent state Sep 30, 2016
petkivim added a commit that referenced this issue Sep 30, 2016
Saving publication after deleting or cancelling an identifier leaves
database in inconsistent state. #29
@petkivim
Copy link
Owner Author

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant