Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a library officer I want to use the length of the latest publisher identifier as a search filter when searching publishers so that I can target my search to a more specific group #41

Closed
petkivim opened this issue Oct 30, 2016 · 3 comments
Closed

As a library officer I want to use the length of the latest publisher identifier as a search filter when searching publishers so that I can target my search to a more specific group #41

petkivim opened this issue Oct 30, 2016 · 3 comments
Labels
enhancement ISBN Component

Comments

@petkivim
Copy link
Owner

petkivim commented Oct 30, 2016 •
edited
Loading

Acceptance criteria:

  • publisher search can be filtered by the length of the latest publisher identifier
  • ISBN filter categories are: 1, 2, 3, 4, 5
  • ISMN filter categories are: 1, 2, 3, 4, 5, 6, 7
  • if publisher has multiple identifiers of different length, only the last identifier matters
petkivim added a commit that referenced this issue Nov 5, 2016
@petkivim
New publisher search filters
6a81c7b 
New publisher search filters added: publisher identifier length. There
are separate filters for ISBN and ISMN pubsliher identifiers. #41
@petkivim
Copy link
Owner Author

petkivim commented Nov 5, 2016

Done. However, the filters are applied to all the identifiers that publisher has, not only to the latest one. In practice this means that the publisher can end up to multiple categories if the publisher has multiple identifiers that belong to different categories.

@petkivim petkivim closed this as completed Nov 5, 2016
@petkivim petkivim reopened this Nov 12, 2016
@petkivim
Copy link
Owner Author

The below criteria must be implemented:

  • if publisher has multiple identifiers of different length, only the last identifier matters

petkivim added a commit that referenced this issue Nov 12, 2016
@petkivim
Publisher category search filter updated.
2b816b6 
Publisher identifier length filter is applied to the latest identifier
only. Each publisher can end up in to one category only.  #41
@petkivim
Copy link
Owner Author

Implementation updated.

@petkivim petkivim mentioned this issue Nov 19, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ISBN Component
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@petkivim